Skip to content

Wycheproof integration #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgarske merged 3 commits into from
Feb 10, 2025
Merged

Wycheproof integration #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a10b174
Wycheproof tests integrated in the hkdf.rs module.
gasbytes Feb 3, 2025
6e1e95a
test: Testing Aes128 and Aes256 against wycheproof-rs's test vectors
gasbytes Feb 4, 2025
9e8418a
test: wycheproof's tests integration in Chacha20 module
gasbytes Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion rustls-wolfcrypt-provider/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ env_logger = { version = "0.11.5", default-features = false }
wolfcrypt-rs = { path = "../wolfcrypt-rs" }
rustls-pemfile = { version = "2.2.0", default-features = false }
hex = { version = "0.4.3", default-features = false, features = ["alloc"]}
wycheproof = "0.6.0"
wycheproof = { version = "0.6.0", default-features = false, features = [
"aead",
"hkdf",
] }
rayon = "1.10.0"
anyhow = "1.0.95"
num_cpus = "1.16.0"
Expand Down
136 changes: 136 additions & 0 deletions rustls-wolfcrypt-provider/src/aead/aes128gcm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@ impl MessageDecrypter for WCTls13Cipher {
#[cfg(test)]
mod tests {
use super::*;
use wycheproof::{aead::TestFlag, TestResult};

#[test]
fn test_aesgcm128() {
Expand Down Expand Up @@ -486,4 +487,139 @@ mod tests {
assert_eq!(result_decrypted, plain);
}
}

#[test]
fn test_aesgcm128_wycheproof() {
let test_name = wycheproof::aead::TestName::AesGcm;
let test_set = wycheproof::aead::TestSet::load(test_name).unwrap();
let mut counter = 0;

for group in test_set
.test_groups
.into_iter()
.filter(|group| group.key_size == 128)
.filter(|group| group.nonce_size == 96)
{
for test in group.tests {
counter += 1;

let mut aes_c_type: Aes = unsafe { mem::zeroed() };
let aes_object = unsafe { AesObject::from_ptr(&mut aes_c_type) };

unsafe {
let ret = wc_AesInit(aes_object.as_ptr(), ptr::null_mut(), INVALID_DEVID);
check_if_zero(ret).unwrap();

let ret = wc_AesGcmSetKey(
aes_object.as_ptr(),
test.key.as_ptr(),
test.key.len() as word32,
);
check_if_zero(ret).unwrap();
}

let mut actual_ciphertext = test.pt.to_vec();
let mut actual_tag = [0u8; GCM_TAG_LENGTH];

let encrypt_result = unsafe {
wc_AesGcmEncrypt(
aes_object.as_ptr(),
actual_ciphertext.as_mut_ptr(),
test.pt.as_ptr(),
test.pt.len() as word32,
test.nonce.as_ptr(),
test.nonce.len() as word32,
actual_tag.as_mut_ptr(),
actual_tag.len() as word32,
test.aad.as_ptr(),
test.aad.len() as word32,
)
};

match &test.result {
TestResult::Invalid => {
if test.flags.iter().any(|flag| *flag == TestFlag::ModifiedTag) {
assert_ne!(
actual_tag[..],
test.tag[..],
"Expected incorrect tag. Id {}: {}",
test.tc_id,
test.comment
);
}
}
TestResult::Valid | TestResult::Acceptable => {
assert_eq!(
encrypt_result, 0,
"Encryption failed for test case {}: {}",
test.tc_id, test.comment
);

assert_eq!(
actual_ciphertext[..],
test.ct[..],
"Encryption failed for test case {}: {}",
test.tc_id,
test.comment
);

assert_eq!(
actual_tag[..],
test.tag[..],
"Tag mismatch in test case {}: {}",
test.tc_id,
test.comment
);
}
}

let mut decrypted_data = test.ct.to_vec();
let decrypt_result = unsafe {
wc_AesGcmDecrypt(
aes_object.as_ptr(),
decrypted_data.as_mut_ptr(),
test.ct.as_ptr(),
test.ct.len() as word32,
test.nonce.as_ptr(),
test.nonce.len() as word32,
test.tag.as_ptr(),
test.tag.len() as word32,
test.aad.as_ptr(),
test.aad.len() as word32,
)
};

match &test.result {
TestResult::Invalid => {
assert!(
decrypt_result != 0,
"Decryption should have failed for invalid test case {}: {}",
test.tc_id,
test.comment
);
}
TestResult::Valid | TestResult::Acceptable => {
assert_eq!(
decrypt_result, 0,
"Decryption failed for test case {}: {}",
test.tc_id, test.comment
);
assert_eq!(
decrypted_data[..],
test.pt[..],
"Decryption failed for test case {}: {}",
test.tc_id,
test.comment
);
}
}
}
}

assert!(
counter > 50,
"Insufficient number of tests run: {}",
counter
);
}
}
136 changes: 136 additions & 0 deletions rustls-wolfcrypt-provider/src/aead/aes256gcm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@ impl MessageDecrypter for WCTls13Cipher {
#[cfg(test)]
mod tests {
use super::*;
use wycheproof::{aead::TestFlag, TestResult};

#[test]
fn test_aesgcm256() {
Expand Down Expand Up @@ -491,4 +492,139 @@ mod tests {
assert_eq!(result_decrypted, plain);
}
}

#[test]
fn test_aesgcm256_wycheproof() {
let test_name = wycheproof::aead::TestName::AesGcm;
let test_set = wycheproof::aead::TestSet::load(test_name).unwrap();
let mut counter = 0;

for group in test_set
.test_groups
.into_iter()
.filter(|group| group.key_size == 256)
.filter(|group| group.nonce_size == 96)
{
for test in group.tests {
counter += 1;

let mut aes_c_type: Aes = unsafe { mem::zeroed() };
let aes_object = unsafe { AesObject::from_ptr(&mut aes_c_type) };

unsafe {
let ret = wc_AesInit(aes_object.as_ptr(), ptr::null_mut(), INVALID_DEVID);
check_if_zero(ret).unwrap();

let ret = wc_AesGcmSetKey(
aes_object.as_ptr(),
test.key.as_ptr(),
test.key.len() as word32,
);
check_if_zero(ret).unwrap();
}

let mut actual_ciphertext = test.pt.to_vec();
let mut actual_tag = [0u8; GCM_TAG_LENGTH];

let encrypt_result = unsafe {
wc_AesGcmEncrypt(
aes_object.as_ptr(),
actual_ciphertext.as_mut_ptr(),
test.pt.as_ptr(),
test.pt.len() as word32,
test.nonce.as_ptr(),
test.nonce.len() as word32,
actual_tag.as_mut_ptr(),
actual_tag.len() as word32,
test.aad.as_ptr(),
test.aad.len() as word32,
)
};

match &test.result {
TestResult::Invalid => {
if test.flags.iter().any(|flag| *flag == TestFlag::ModifiedTag) {
assert_ne!(
actual_tag[..],
test.tag[..],
"Expected incorrect tag. Id {}: {}",
test.tc_id,
test.comment
);
}
}
TestResult::Valid | TestResult::Acceptable => {
assert_eq!(
encrypt_result, 0,
"Encryption failed for test case {}: {}",
test.tc_id, test.comment
);

assert_eq!(
actual_ciphertext[..],
test.ct[..],
"Encryption failed for test case {}: {}",
test.tc_id,
test.comment
);

assert_eq!(
actual_tag[..],
test.tag[..],
"Tag mismatch in test case {}: {}",
test.tc_id,
test.comment
);
}
}

let mut decrypted_data = test.ct.to_vec();
let decrypt_result = unsafe {
wc_AesGcmDecrypt(
aes_object.as_ptr(),
decrypted_data.as_mut_ptr(),
test.ct.as_ptr(),
test.ct.len() as word32,
test.nonce.as_ptr(),
test.nonce.len() as word32,
test.tag.as_ptr(),
test.tag.len() as word32,
test.aad.as_ptr(),
test.aad.len() as word32,
)
};

match &test.result {
TestResult::Invalid => {
assert!(
decrypt_result != 0,
"Decryption should have failed for invalid test case {}: {}",
test.tc_id,
test.comment
);
}
TestResult::Valid | TestResult::Acceptable => {
assert_eq!(
decrypt_result, 0,
"Decryption failed for test case {}: {}",
test.tc_id, test.comment
);
assert_eq!(
decrypted_data[..],
test.pt[..],
"Decryption failed for test case {}: {}",
test.tc_id,
test.comment
);
}
}
}
}

assert!(
counter > 50,
"Insufficient number of tests run: {}",
counter
);
}
}
Loading