Merged
Conversation
bigbrett
requested changes
Jul 10, 2025
Contributor
bigbrett
left a comment
bigbrett
left a comment
There was a problem hiding this comment.
Can we make these new functionalities self-contained demos in the demo directory, rather than done inline in the client example driver?
Contributor
Author
Concur. Great idea. I'll switch this to draft as I rework. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enriches the wolfHSM demos by adding a full secure-boot workflow (provision, boot, zeroize), extends the TCP client/server examples with multiple crypto contexts, and standardizes demo header guards.
- Added secure-boot examples (
wh_demo_client_secboot.c) with provisioning, measurement, signing, verification, and zeroization. - Extended
wh_server_tcp.candwh_client_tcp.cto showcase software/hardware RNG contexts and added shared sleep/hex-dump helpers. - Renamed and unified header guards across all demo client headers and updated the demo driver to invoke the new examples.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/posix/tcp/wh_server_tcp/wh_server_tcp.c | Added _SleepMs, _HexDump, hardware RNG callback, and server crypto contexts for demos |
| examples/posix/tcp/wh_client_tcp/wh_client_tcp.c | Added _SleepMs, _HexDump and two client RNG contexts |
| examples/demo/client/wh_demo_client_wctest.h | Updated include guard to DEMO_CLIENT_WCTEST_H_ |
| examples/demo/client/wh_demo_client_wctest.c | Fixed include from counter to wctest header |
| examples/demo/client/wh_demo_client_wcbench.h | Updated include guard to DEMO_CLIENT_WCBENCH_H_ |
| examples/demo/client/wh_demo_client_secboot.h | Introduced secure-boot demo function declarations |
| examples/demo/client/wh_demo_client_secboot.c | Implemented provisioning, boot, and zeroize workflows |
| examples/demo/client/wh_demo_client_nvm.h | Updated include guard to DEMO_CLIENT_NVM_H_ |
| examples/demo/client/wh_demo_client_nvm.c | Reordered and cleaned up includes |
| examples/demo/client/wh_demo_client_keystore.h | Updated include guard to DEMO_CLIENT_KEYSTORE_H_ |
| examples/demo/client/wh_demo_client_keystore.c | Reordered and cleaned up includes |
| examples/demo/client/wh_demo_client_crypto.h | Updated include guard to DEMO_CLIENT_CRYPTO_H_ |
| examples/demo/client/wh_demo_client_crypto.c | Reordered and cleaned up includes |
| examples/demo/client/wh_demo_client_counter.h | Updated include guard to DEMO_CLIENT_COUNTER_H_ |
| examples/demo/client/wh_demo_client_counter.c | Fixed include order |
| examples/demo/client/wh_demo_client_all.h | Updated include guard to DEMO_CLIENT_ALL_H_ |
| examples/demo/client/wh_demo_client_all.c | Added SecBoot routines to the demo driver |
bigbrett
requested changes
Jul 22, 2025
Contributor
bigbrett
left a comment
bigbrett
left a comment
There was a problem hiding this comment.
good addition. One typo that needs to be fixed, and a few other small things that could be punted or addressed
bigbrett
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 3 additional examples into the client demos:
Added crypto examples for 5 different usage context: