Makefile and minor code changes to unify builds for porting and testing #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update yml files to seperate make and run steps Add strings.h to help posix compile Ensure posix version is checked force posix version for pread/pwrite force earlier inclusion of source version definition remove posix_cfg.h. update makefile instead correct makefiles replace deprecated usleep with nanosleep add garbage collection to avoid unused dependencies
billphipps
force-pushed
the
support_wildcard_wolfcrypt
branch
from
56f4f00 to
5e088f4
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR unifies and standardizes the build system across wolfHSM's test, example, and benchmark components by updating Makefiles and configuration settings. It also addresses POSIX compliance issues and improves code portability.
- Updates Makefiles to use wildcard inclusion patterns for source files instead of explicit file lists
- Replaces obsolete
usleepwith POSIX-compliantnanosleepfor better portability - Standardizes C90 compliance and adds proper POSIX C source version declarations
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Makefile | Major refactor to use wildcards, standardize compiler flags, and improve organization |
| test/wh_test_comm.c | Replaces usleep with nanosleep for POSIX compliance |
| test/config/user_settings.h | Reorganizes defines and adds POSIX strcasecmp support |
| benchmark/Makefile | Similar refactor to use wildcards and standardized structure |
| examples/posix/tcp/*/Makefile | Consistency improvements with wildcard patterns |
| .github/workflows/*.yml | Separates build and run commands in CI workflows |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bigbrett
requested changes
Sep 4, 2025
Contributor
bigbrett
left a comment
bigbrett
left a comment
There was a problem hiding this comment.
LGTM - just fix one comment and resolve the copilot review items if they aren't real and I can merge
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Brett Nicholas <[email protected]>
bigbrett
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on MacOS. Github runners