Merged
Conversation
AlexLanzano
force-pushed
the
keywrap-feature
branch
3 times, most recently
from
fd4ab14 to
7e85b55
Compare
billphipps
previously requested changes
Sep 8, 2025
Contributor
billphipps
left a comment
billphipps
left a comment
There was a problem hiding this comment.
Looks like a great start! I think there are few items we should discuss from a design perspective. Let me know about my comments and how you want to proceed
bigbrett
requested changes
Sep 12, 2025
Contributor
bigbrett
left a comment
bigbrett
left a comment
There was a problem hiding this comment.
Incomplete review - just some quick nits up front about naming and organization
AlexLanzano
force-pushed
the
keywrap-feature
branch
from
c3c4934 to
614556e
Compare
This provides a client and server API to request/handle requests to wrap a plaintext key, unwrap a wrapped key, and cache a wrapped key.
AlexLanzano
force-pushed
the
keywrap-feature
branch
from
614556e to
f72306c
Compare
AlexLanzano
force-pushed
the
keywrap-feature
branch
2 times, most recently
from
9164df3 to
845a276
Compare
AlexLanzano
force-pushed
the
keywrap-feature
branch
from
845a276 to
a6fd3c0
Compare
bigbrett
requested changes
Sep 19, 2025
Contributor
bigbrett
left a comment
bigbrett
left a comment
There was a problem hiding this comment.
Amazing work @AlexLanzano. A few final tweaks and it is good to go
- Add braces to all braceless if statements - Validate group, action, and response size on all key wrap response handling functions - Replace non-portable bool type with int - Misc style fixes
AlexLanzano
force-pushed
the
keywrap-feature
branch
from
ad30213 to
51f171e
Compare
Some of the static strings in wolfHSM aren't accounting for the terminating NULL character which throws a "unterminated-string-initialization" error in GCC version 15.2.1. Address this by either changing the string to an array or increasing the string array size
AlexLanzano
force-pushed
the
keywrap-feature
branch
from
0f29e11 to
10a7f04
Compare
AlexLanzano
force-pushed
the
keywrap-feature
branch
from
10a7f04 to
5fdbe71
Compare
bigbrett
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.