Disable server functions into client only and vis-vrsa #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbrett
requested changes
Sep 17, 2025
Contributor
bigbrett
left a comment
bigbrett
left a comment
There was a problem hiding this comment.
Hi @miyazakh,
I believe you have the macro protection wrong. The client functions are "SendRequest" and "RecvResponse", and the Server functions are "RecvRequest" and "SendResponse". Look at how the callbacks are bound to send/recv.
bigbrett
reviewed
Sep 17, 2025
bigbrett
requested changes
Sep 18, 2025
bigbrett
approved these changes
Sep 22, 2025
Contributor
bigbrett
left a comment
bigbrett
left a comment
There was a problem hiding this comment.
I just realized that the client/server init functions in the POSIX shm transport are not protected by `WOLFHSM_. However that file is being actively modified by @JacobBarthelmeh in #158. I'll leave that additional fix to him.
This was referenced Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable server functions into Client only:
wh_TransportMem_SendRequest
wh_TransportMem_RecvResponse
Disable client functions into Server only:
wh_TransportMem_SendResponse
wh_TransportMem_RecvRequest
Issue#128