Fixes scan-build issues

[miyazakh]

Fixes issues on scan-build LLVM-19

scan-build --status-bugs make -C test/ 
scan-build --status-bugs make -C benchmark/ 
scan-build --status-bugs make -C examples/ 
scan-build --status-bugs make -C tools/whnvmtool/

There is one issue, which is warning: Value stored to 'ret' is never read in wolfcrypt\src\random.c against tools/whnvmtool/, remaining. That will be separately fixed.

Github action addition for changes in the future will be submitted as separate PR.

[JacobBarthelmeh]

Overall looks great. Only thing that stood out to me is the loss of capturing return values. I think we should act on the return values if scan-build is complaining about them not being used, or the internal function should be changed to a void return if no return values are expected.

[bigbrett]

@miyazakh looks like there are merge conflicts. Can you please address my comments as well as resolve them.

I also would like to see scan-build integrated as a GH action

[miyazakh]

clang-tidy starts complaining to wh_server_keystore.c even though the PR doesn't touch it.

[bigbrett]

clang-tidy starts complaining to wh_server_keystore.c even though the PR doesn't touch it.

@miyazakh Should be fixed if you rebase on main, sorry about that!

[billphipps]

Looks good! A few minor suggestions and a couple of questions. This should be merged prior to #158.

[billphipps]

Lots of excellent fixes and finds! Thank you!

I recommend we ignore some of the error returns as in the original code. Let me know if you agree or if we should find an alternate path on how to handle secondary errors.

I think exiting early during reading the NVM directory objects is an error and must be corrected.

[bigbrett]

@billphipps please merge when you are ok with it

[billphipps]

Looks great! Thanks!