Merged
Conversation
9e6a072 added a enum that adds a name clashes when WOLFHSM_CFG_DMA_CUSTOM_CLIENT_COPY is defined. As the enum looks unused, it's probably just a artifact of a refactoring.
Contributor
|
@JacobBarthelmeh's PR introduced wh_dma.h which is a central place for all core DMA functionality. @rizlik do you think this might be a better home for these macros than wh_server.h? |
JacobBarthelmeh
previously approved these changes
Oct 2, 2025
Contributor
JacobBarthelmeh
left a comment
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Sorry @rizlik, thanks for fixing the duplication of enums. Maybe consider deleting the wh_server.h location and leaving the wh_dma.h spot, this change fixes the issue though.
Contributor
Author
|
moved in the dma.h and added the typedef |
JacobBarthelmeh
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9e6a072 added a enum that adds a name clashes when WOLFHSM_CFG_DMA_CUSTOM_CLIENT_COPY is defined. As the enum looks unused, it's probably just a artifact of a refactoring.