Skip to content

fix: correct variable in MQTT property decode error checks #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
embhorn merged 1 commit into from
Nov 10, 2025
Merged

fix: correct variable in MQTT property decode error checks #445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/mqtt_packet.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,8 +1238,8 @@ int MqttDecode_PublishResp(byte* rx_buf, int rx_buf_len, byte type,
}
props_tmp = MqttDecode_Vbi(rx_payload, &props_len,
(word32)(rx_buf_len - (rx_payload - rx_buf)));
if (tmp < 0)
return tmp;
if (props_tmp < 0)
return props_tmp;

if (props_len <= (word32)(rx_buf_len - (rx_payload - rx_buf))) {
rx_payload += props_tmp;
Expand Down Expand Up @@ -1548,8 +1548,8 @@ int MqttDecode_UnsubscribeAck(byte *rx_buf, int rx_buf_len,
}
props_tmp = MqttDecode_Vbi(rx_payload, &props_len,
(word32)(rx_buf_len - (rx_payload - rx_buf)));
if (tmp < 0)
return tmp;
if (props_tmp < 0)
return props_tmp;

if (props_len <= (word32)(rx_buf_len - (rx_payload - rx_buf))) {
rx_payload += props_tmp;
Expand Down