Skip to content

Don't alloc zero bytes on an empty array #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LinuxJedi wants to merge 1 commit into from
Closed

Don't alloc zero bytes on an empty array #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/internal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1779,6 +1779,11 @@ static int wp11_storage_read_alloc_array(void* storage,
/* Read length of array. */
ret = wp11_storage_read_int(storage, len);
if (ret == 0) {
if (*len == 0) {
Copy link
Collaborator

@dgarske dgarske Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to see about solving the malloc of 0 instead. I am going to open a new PR with a few other fixes.

XFREE(*buffer, NULL, DYNAMIC_TYPE_TMP_BUFFER);
*buffer = NULL;
return 0;
}
/* Allocate buffer to hold data. */
*buffer = (unsigned char*)XMALLOC(*len, NULL, DYNAMIC_TYPE_TMP_BUFFER);
if (*buffer == NULL)
Expand Down
Loading