Skip to content

Conversation

@LinuxJedi
Copy link
Member

@LinuxJedi LinuxJedi commented Aug 13, 2025

The cmsutil and ssltap tests were not actually testing wolfPKCS11, and this wasn't clear until the GitHub Actions cached was purged. This caused them to start failing on all PRs.

This PR:

  • Drops the usage of pk12util, this requires custom NSS functions that we probably cannot implement in FIPSv5
  • Adds the CKA_NSS_EMAIL attribute for certificates (needed for certutil)
  • Fixes issues in the NSS config string parser (required for ssltap)
    • Empty quoted values aborted with error instead of skipping
    • Values that were not surrounded with quotes broke the parser
  • Fixes ssltap test not actually compiling / installing wolfPKCS11

@LinuxJedi LinuxJedi changed the title Drop the pk12util usage Fix failing GitHub Actions tests Aug 13, 2025
@LinuxJedi LinuxJedi marked this pull request as ready for review August 13, 2025 17:41
@dgarske dgarske merged commit 93a21f5 into wolfSSL:master Aug 15, 2025
53 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants