-
Notifications
You must be signed in to change notification settings - Fork 20
STM32U5 DHUK wrapping use #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds STM32U5 DHUK (Derived Hardware Unique Key) wrapping functionality to wolfPKCS11. It introduces device ID tracking per object to enable hardware-specific cryptographic operations, particularly for STM32U5 microcontrollers with dedicated hardware key wrapping capabilities.
- Adds device ID attribute support for PKCS11 objects to track which cryptographic hardware should be used
- Updates all cryptographic operations to use object-specific device IDs instead of session/slot device IDs
- Implements STM32U5 DHUK key wrapping with hardware acceleration support
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| wolfpkcs11/pkcs11.h | Adds CKA_DEVID attribute definition and CK_INT typedef for device ID support |
| wolfpkcs11/internal.h | Declares new WP11_Object_GetDevId function |
| src/internal.c | Implements device ID tracking per object and updates all crypto operations to use object devId |
| src/crypto.c | Adds DHUK wrapping support and CKA_DEVID attribute handling |
| examples/stm32_dhuk_aes_key.c | Provides example implementation demonstrating DHUK key wrapping functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
LinuxJedi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor things I spotted on the PKCS11 side of things, I didn't dig into the STM32 side.
dgarske
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks great. Tested on Pi with real TPM.
No description provided.