Fix empty PIN handling for FIPS #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When PBKDF2 is used for PIN handling, if the pin is too small, this produces an error. This breaks our ability to have empty PINs. Instead, we used a padded empty value.
dgarske
requested changes
Aug 29, 2025
dgarske
requested changes
Aug 29, 2025
Collaborator
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Discussed with Andrew. This workaround for NSS trying to use a zero length pin is fine. For the cases where a PIN < HMAC_MIN_KEYLEN (14) it should produce an error in FIPS mode. Add WOLFPKCS11_NSS around it and code comment.
dgarske
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When PBKDF2 is used for PIN handling, if the pin is too small, this produces an error. This breaks our ability to have empty PINs.
Instead, we used a padded empty value.