Add support for AES-CCM. #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobBarthelmeh
previously requested changes
Dec 6, 2024
Contributor
JacobBarthelmeh
left a comment
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Have a small comment about the configure.ac setup. Rest looks good, thanks!
douzzer
requested changes
Dec 17, 2024
Contributor
douzzer
left a comment
douzzer
left a comment
There was a problem hiding this comment.
It's super-confusing having the wolfPKCS11 configure give the developer control of, and status of, all of the supported ciphers+modes except for AES-CCM. There should be a --enable-aesccm and * AES-CCM: yes (or no) as for the others, else devs will wonder where CCM is, or if there's something special about CCM.
Unrelated to the above, and probably unrelated to the PR, but reproducible when built with current wolfssl master:
tests/pkcs11test.c:4650 - Get Attributes EC private key params length - FAIL
tests/pkcs11mtt.c:3644 - Get Attributes EC private key params length - FAIL
douzzer
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test created and passed.