Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

Fix for version.h Changes After Builds

This PR fixes the issue where include/wolfprovider/version.h was being modified after each build. The solution implements the same approach used in wolfSSL for handling version headers.

Changes

  1. Added the missing hexversion.m4 macro from wolfSSL to wolfProvider
  2. Modified configure.ac to include the hexversion.m4 file and call the CREATE_HEX_VERSION macro
  3. Updated the version.h file to directly include the hex version value instead of using the @HEX_VERSION@ placeholder

Testing

Verified the fix by running the build script multiple times, and version.h no longer shows as modified in git status after building.

Link to Devin run: https://app.devin.ai/sessions/363610d57a8240da90a6ff27f5ab99e4
Requested by: [email protected]

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@padelsbach padelsbach self-requested a review April 28, 2025 17:04
@padelsbach padelsbach force-pushed the devin/1745348721-version-header-fix-v2 branch from 9157397 to c53faa9 Compare April 28, 2025 17:19
@padelsbach padelsbach requested a review from ColtonWilley April 28, 2025 17:32
@ColtonWilley ColtonWilley merged commit 2b57ff2 into master Apr 28, 2025
44 checks passed
@aidangarske aidangarske deleted the devin/1745348721-version-header-fix-v2 branch August 29, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants