Skip to content

Conversation

@aidangarske
Copy link
Contributor

Description

  • Fixes version inconsistency error with openssl
  • Uses a cache key like wolfssl so we get a clean build every time we invoke a test workkflow

@aidangarske aidangarske self-assigned this May 19, 2025
@aidangarske aidangarske marked this pull request as ready for review May 19, 2025 22:46
@aidangarske aidangarske requested review from Copilot and padelsbach and removed request for Copilot May 19, 2025 22:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the cache key used for the OpenSSL version build cache to include the commit SHA and adds lookup-only restores for a clean, per-commit build.

  • Normalize cache key across all workflows to ossl-depends-${{ matrix.openssl_ref }}-${{ github.sha }}
  • Introduce lookup-only: true on initial restore and enforce fail-on-cache-miss: true on the subsequent restore
  • Applies the change consistently across 14 different GitHub Actions workflows

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/stunnel.yml Updated cache key, added lookup-only flag, enforced fail-on-cache-miss
.github/workflows/sssd.yml Same as above
.github/workflows/socat.yml Same as above
.github/workflows/simple.yml Same as above
.github/workflows/openvpn.yml Same as above
.github/workflows/openssh.yml Same as above
.github/workflows/openldap.yml Same as above (plus toggled fail-on-cache-miss)
.github/workflows/nginx.yml Same as above
.github/workflows/ipmitool.yml Same as above (plus toggled fail-on-cache-miss)
.github/workflows/grpc.yml Same as above (plus toggled fail-on-cache-miss)
.github/workflows/curl.yml Same as above
Comments suppressed due to low confidence (1)

.github/workflows/stunnel.yml:53

  • Including github.sha in the cache key will generate a unique key per commit, preventing cache hits across workflow runs and defeating the cache benefit. Consider using a stable key based solely on the OpenSSL version (e.g. ${{ matrix.openssl_ref }}) or leverage restore-keys to fall back to previous caches when the key changes.
key: ossl-depends-${{ matrix.openssl_ref }}-${{ github.sha }}

Copy link
Contributor

@padelsbach padelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix

@douzzer douzzer merged commit 6daa186 into wolfSSL:master May 20, 2025
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants