-
Notifications
You must be signed in to change notification settings - Fork 28
disables MD5 on FIPS builds and adds WP_ALLOW_NON_FIPS flag #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
padelsbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Will let @ColtonWilley chime in
|
I am not so sure about this one. In general wolfProvider is not the one who determines algo support, it relies on the wolfssl includes to dictate which algos are enabled. There are no other switches in settings.h on FIPS, despite many of those algos also not being included in the FIPS module. At a minimum it makes the code inconsistent, 3DES would also fall into this same category. We should either not enforce, or enforce in a robust and consistent way. Let me think some more and consult with Kaleb on this. |
@ColtonWilley in the XXX-fips-test directory MD5 is enabled by default. Would updating this to disabled by default be better? 3DES is disabled by defualt here. |
2748565 to
3c9d4ca
Compare
|
retest this please Jenkins |
MD5 was getting enabled on FIPS builds which shouldn't be happening. Added
WP_ALLOW_NON_FIPSflag to allow usage of DES3 or MD5 if they are enabled in the FIPS build.