Skip to content

Conversation

@aidangarske
Copy link
Contributor

Description

  • Adds a WOLFPROV_LEAVE_SILENT macro and WOLFPROV_ENTER_NOEXIT macro pair that can be used with --debug and --leave-silent to suppress decode functions called by wp_*_decode() and functions that return 0 but are not actually failures like *_does_selection functions.
  • This is not on by default because this could suppress real errors that return from decode functions. That said you can enable this but calling functions will need to be able to handle the failure case which in most cases would return correctly if called right. Either way in the output it will not show up.
  • The WOLFPROV_ENTER_NOEXIT macro specifically adds a [NOEXIT] tag to the output of functions so users will know that there will be no leave function associated with the enter function.
  • The goal with this was to reduce the clutter of "false" return 0's we get in various tests. When testing the ./scripts/cmd_test/do-cmd-test.sh` we got 1092 return 0's with unit test we get 206. After our changes we get 30 and 127 respectively the failures in unit test are ofc neg testing failures and the 30 in cmd test are expected behavior but shouldn't be suppressed.

@aidangarske aidangarske self-assigned this Aug 15, 2025
@aidangarske aidangarske marked this pull request as ready for review August 15, 2025 22:43
ColtonWilley
ColtonWilley previously approved these changes Aug 18, 2025
padelsbach
padelsbach previously approved these changes Aug 20, 2025
ColtonWilley
ColtonWilley previously approved these changes Aug 20, 2025
@ColtonWilley ColtonWilley merged commit 5b90320 into wolfSSL:master Aug 21, 2025
464 of 473 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants