Run the FIPS CAST tests under lock during wolfprovider init#319
Merged
padelsbach merged 2 commits intowolfSSL:masterfrom Oct 28, 2025
Merged
Run the FIPS CAST tests under lock during wolfprovider init#319padelsbach merged 2 commits intowolfSSL:masterfrom
padelsbach merged 2 commits intowolfSSL:masterfrom
Conversation
padelsbach
previously approved these changes
Oct 27, 2025
Contributor
padelsbach
left a comment
padelsbach
left a comment
There was a problem hiding this comment.
Looks good. Some minor suggestions
padelsbach
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem in the bind9 make check where threads raced on the FIPS CAST tests, causing a CAST error. Use mutex initializers during dyanmic loading to sync threads calls to the CAST tests.