wolfTPM Zephyr Project Port #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
previously approved these changes
Jan 23, 2025
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Wonderful work. As you get time please add a GitHub CI test. @ColtonWilley please review also.
Contributor
|
Please resolve merge conflicts. |
night1rider
force-pushed
the
tpm_zephyr_support
branch
from
d017750 to
8ed8df9
Compare
Contributor
|
Rebased/Merge conflict fixed |
night1rider
force-pushed
the
tpm_zephyr_support
branch
from
4a2361e to
b2888d7
Compare
dgarske
force-pushed
the
tpm_zephyr_support
branch
from
6355e86 to
8390676
Compare
dgarske
requested changes
Mar 24, 2025
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
The test issue was due to a filename 'sample.ymlneeded to besample.yaml`.
Tests are now failing with:
/home/davidgarske/zephyr-3.4.0/zephyr/modules/lib/wolftpm/zephyr/samples/wolftpm_wrap_test/prj.conf:6: warning: attempt to assign the value 'y' to the undefined symbol WOLFTPM
/home/davidgarske/zephyr-3.4.0/zephyr/modules/lib/wolftpm/zephyr/samples/wolftpm_wrap_test/prj.conf:15: warning: attempt to assign the value 'y' to the undefined symbol WOLFSSL
/home/davidgarske/zephyr-3.4.0/zephyr/modules/lib/wolftpm/zephyr/samples/wolftpm_wrap_test/prj.conf:16: warning: attempt to assign the value 'y' to the undefined symbol WOLFSSL_BUILTIN
@aidangarske will you take a look?
dgarske
force-pushed
the
tpm_zephyr_support
branch
from
4cfcc91 to
920307c
Compare
aidangarske
force-pushed
the
tpm_zephyr_support
branch
from
8bf12bf to
8b8bd47
Compare
aidangarske
requested review from
dgarske and
night1rider
and removed request for
ColtonWilley
dgarske
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the pr for adding Zephyr support for wolfTPM. I added
wolftpm_wrap_testandwolftpm_wrap_capssamples. Each one builds successfully. Theuser_settings.hin the zephyr project is used correctly. that means if you want to supply your own you can either change the file or add yours in place.Testing
setup Zephyr module in zephyrproject and build samples:
A
zephyr.ymlGithub CI workflow was added to test builds.Documentation
For now I have made a zephyr/README.md with all the information needed to get started.