examples: bench: Fix handle leak in bench_sym_hash #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one of the TPM2 functions called from bench_sym_hash returns an error, the exit path won't unload the hash handle leaving it dangling. This could eventually lead to OOM TPM issues (like TPM2_RC_OBJECT_MEMORY). Unload the handle on the exit path if rc is non-zero. Signed-off-by: Ivan Orlov <[email protected]>
Contributor
|
Thank you @iorlov-dev for this report! As this is a small fix, I've treated this as a bug report and put up a fix here: #412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one of the TPM2 functions called from bench_sym_hash returns an error, the exit path won't unload the hash handle leaving it dangling. This could eventually lead to OOM TPM issues (like TPM2_RC_OBJECT_MEMORY).
Unload the handle on the exit path if rc is non-zero.