Skip to content

Conversation

@dgarske
Copy link
Contributor

@dgarske dgarske commented May 29, 2025

  • Fixed logic for signing with input digest smaller than key size. ZD 19869
  • Improved input digest size logic for TPM2_Sign and TPM2_Verify.
  • Added test case for ECC sign/verify with various digest input sizes.
  • Exposed TPM2_ASN_TrimZeros.
  • Fixed test_TPM2_PCRSel test.

@dgarske dgarske self-assigned this May 29, 2025
@dgarske dgarske force-pushed the tpmsign branch 2 times, most recently from f592053 to f9167ce Compare May 29, 2025 18:55
@dgarske dgarske assigned wolfSSL-Bot and embhorn and unassigned dgarske May 29, 2025
@dgarske dgarske requested a review from embhorn May 29, 2025 20:21
Copy link
Member

@embhorn embhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing a failure with the new test

ERROR - tests/unit_tests.c line 432 failed with:
    expected: rc == 0
    result:   707(0x2c3) != 0(0x0)

RPi3 with SLB9670

@dgarske
Copy link
Contributor Author

dgarske commented May 30, 2025

I am seeing a failure with the new test

ERROR - tests/unit_tests.c line 432 failed with:
    expected: rc == 0
    result:   707(0x2c3) != 0(0x0)

RPi3 with SLB9670

It does not support ECC384. Let me resolve that with a run-time detection.

@dgarske dgarske self-assigned this May 30, 2025
@dgarske dgarske requested a review from embhorn May 31, 2025 01:11
@dgarske dgarske removed their assignment May 31, 2025
embhorn
embhorn previously approved these changes Jun 2, 2025
Copy link
Member

@embhorn embhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, tests are passing now

embhorn
embhorn previously approved these changes Jun 2, 2025
@embhorn embhorn merged commit bd68255 into wolfSSL:master Jun 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants