Example for HMAC with persistent key #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tart` -> `wolfTPM2_LoadKeyedHashKey`.
There was a problem hiding this comment.
Pull Request Overview
Adds a persistent-key HMAC example and integrates it into the build and test scripts, plus minor behavior tweaks in the wrapper.
- Capture
usageAuthonly when provided inwolfTPM2_HmacStart - New
hmacexample source and build inclusion - Enhanced run script to execute HMAC tests
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tpm2_wrap.c | Guarded auth copy on usageAuth != NULL |
| examples/wrap/wrap_test.h | Declared TPM2_Wrapper_Hmac prototypes |
| examples/wrap/include.am | Added hmac example to build targets |
| examples/wrap/hmac.c | New HMAC example implementation |
| examples/tpm_test.h | Defined TPM2_DEMO_HMAC_KEY_HANDLE |
| examples/run_examples.sh | Added HMAC test invocations in CI script |
Comments suppressed due to low confidence (1)
examples/run_examples.sh:141
- There's no test for the
-keepoption. Consider adding a./examples/wrap/hmac -keepinvocation to ensure the persistent-key behavior is covered in CI.
./examples/wrap/hmac >> $TPMPWD/run.out 2>&1
embhorn
approved these changes
Jul 1, 2025
Member
embhorn
left a comment
embhorn
left a comment
There was a problem hiding this comment.
Looks good and tests successfully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example for HMAC with persistent key. ZD 20109.