JCE: fix Cipher.getOutputSize() for AES/GCM/NoPadding in DECRYPT mode#107
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Mar 24, 2025
Merged
Conversation
…, should remove tag from length
JacobBarthelmeh
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
Cipher(AES/GCM/NoPadding)behavior forgetOutputSize(int inputLen)to correctly strip off the tag length from the expected output size when in DECRYPT mode.Adds JUnit tests to prevent regression.
We should revisit other algos/modes to see if they need similar adjustments. That will be part of follow up PRs if needed.
ZD 19367