Testing: add GitHub action to test Windows Visual Studio (IDE/WIN) project#130
Merged
rlm2002 merged 2 commits intowolfSSL:masterfrom Jul 24, 2025
Merged
Testing: add GitHub action to test Windows Visual Studio (IDE/WIN) project#130rlm2002 merged 2 commits intowolfSSL:masterfrom
IDE/WIN) project#130rlm2002 merged 2 commits intowolfSSL:masterfrom
Conversation
cconlon
force-pushed
the
ghActionWinVS
branch
2 times, most recently
from
ec64c5d to
bc06132
Compare
cconlon
force-pushed
the
ghActionWinVS
branch
4 times, most recently
from
32071b3 to
489f2ce
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comprehensive GitHub Actions workflow to test the Windows Visual Studio project files (IDE/WIN) for the wolfCryptJNI repository. The workflow includes automated building of both wolfSSL and wolfCryptJNI DLLs, along with running JUnit tests specifically for the Windows x64 Release configuration.
- Adds a new reusable Windows Visual Studio workflow with Visual Studio environment auto-detection
- Integrates the new workflow into the main CI pipeline
- Updates test code to handle platform-specific feature availability for HmacSHA224
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/windows-vs.yml | New comprehensive workflow for Windows Visual Studio builds with VS environment detection, DLL building, and testing |
| .github/workflows/main.yml | Integration of the new Windows VS workflow into the main CI pipeline |
| src/test/java/com/wolfssl/provider/jce/test/WolfCryptKeyGeneratorTest.java | Added feature detection for HmacSHA224 to skip tests when not supported by native wolfSSL |
rlm2002
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new GitHub action that tests the Windows Visual Studio project file and solution that ships with this repository (
IDE/WIN). Currently only testing the non-FIPS configuration.