Build fixes for older wolfSSL or FIPS variants#133
Merged
rlm2002 merged 2 commits intowolfSSL:masterfrom Jul 24, 2025
Merged
Conversation
…e FIPS build variants
There was a problem hiding this comment.
Pull Request Overview
This PR addresses compatibility issues with older wolfSSL versions and FIPS variants by making two targeted changes to improve build compatibility across different wolfSSL configurations.
- Removes explicit inclusion of
wolfssl/wolfcrypt/oid_sum.hheader that may not be available in older builds - Adds conditional definition of
DH_MAX_SIZEmacro for older versions and FIPS variants that lack this definition
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| jni/jni_asn.c | Removes explicit inclusion of oid_sum.h header for older build compatibility |
| jni/jni_dh.c | Adds conditional DH_MAX_SIZE definition with platform-specific logic for older/FIPS builds |
rlm2002
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two small fixes for older wolfSSL build or FIPS build compatibility:
wolfssl/wolfcrypt/oid_sum.h. It is not available in older builds, and gets pulled in automatically by other headers in newer builds anyways.DH_MAX_SIZEif not defined in native wolfSSL. Some older versions and FIPS variants don't have this defined.