Add Cipher.getInstance("AES") support#142
Merged
rlm2002 merged 1 commit intowolfSSL:masterfrom Aug 21, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the generic "AES" cipher specification to maintain compatibility with SunJCE and Bouncy Castle providers. The generic "AES" transform is mapped to "AES/ECB/PKCS5Padding" following the behavior of other standard providers.
- Registers "AES" as an alias to the existing AES/ECB/PKCS5Padding cipher implementation
- Adds comprehensive test coverage for the new generic AES cipher support
- Updates documentation to reflect the new alias availability
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/com/wolfssl/provider/jce/WolfCryptProvider.java | Registers the "AES" cipher alias mapping to AES/ECB/PKCS5Padding |
| src/test/java/com/wolfssl/provider/jce/test/WolfCryptCipherTest.java | Adds "AES" to test arrays, implements dedicated test method, and updates IV consistency logic |
| README_JCE.md | Documents the new AES alias in the supported algorithms list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/test/java/com/wolfssl/provider/jce/test/WolfCryptCipherTest.java
Outdated
Show resolved
Hide resolved
45eb278 to
36c41bd
Compare
…adding, along with tests
36c41bd to
b81af66
Compare
rlm2002
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the generic "AES" Cipher type (ex:
Cipher.getInstance("AES");). Both SunJCE and Bouncy Castle map this to "AES/ECB/PKCS5Padding" internally, so we do the same here for compatibility.This fixes one OpenJDK SunJCE test:
crypto/Cipher/GCMAPI.java