Add JCE support for HmacSHA3 KeyGenerator#150
Merged
rlm2002 merged 1 commit intowolfSSL:masterfrom Aug 29, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for HmacSHA3 key generation variants to the JCE provider, extending the existing HmacSHA3 support that was already available in the Mac class to include KeyGenerator functionality.
- Adds four new HmacSHA3 algorithm types (224, 256, 384, 512) to the KeyGenerator enum and implementation
- Registers new KeyGenerator classes for each HmacSHA3 variant in the WolfCryptProvider
- Includes comprehensive JUnit tests with feature detection to ensure compatibility with native wolfSSL builds
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WolfCryptKeyGenerator.java | Implements HmacSHA3 algorithm support with new enum values and KeyGenerator classes |
| WolfCryptProvider.java | Registers the new HmacSHA3 KeyGenerator implementations with feature detection |
| WolfCryptKeyGeneratorTest.java | Adds comprehensive test coverage for all four HmacSHA3 variants |
| README_JCE.md | Documents the newly supported HmacSHA3 KeyGenerator algorithms |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rlm2002
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements HmacSHA3 variant support in
KeyGenerator. We already had HmacSHA3 support in theMacclass, but not yet inKeyGenerator:JUnit tests are included here for regression. This fixes the OpenJDK SunJCE test:
crypto/provider/Mac/MacKAT.java