Add toString() to WolfCryptRandom, init fixes for serialization#154
Merged
rlm2002 merged 2 commits intowolfSSL:masterfrom Sep 10, 2025
Merged
Add toString() to WolfCryptRandom, init fixes for serialization#154rlm2002 merged 2 commits intowolfSSL:masterfrom
rlm2002 merged 2 commits intowolfSSL:masterfrom
Conversation
…on when input arrays are null
There was a problem hiding this comment.
Pull Request Overview
This PR adds toString() implementation to WolfCryptRandom and fixes serialization edge cases by ensuring the RNG is properly initialized when methods are called. The changes improve compatibility with OpenJDK SunJCE DRBG tests.
- Added toString() method returning standardized DRBG string format
- Implemented lazy initialization pattern to handle serialization/deserialization scenarios
- Added comprehensive JUnit tests for serialization/deserialization functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| WolfCryptRandom.java | Added toString() method, lazy RNG initialization, and null parameter validation |
| WolfCryptRandomTest.java | Added serialization/deserialization test with helper methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…s some serialization use cases
rlm2002
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
toString()implementation toWolfCryptRandom, which returns the proper string details that are expected from printing aSecureRandomobject.It also makes sure
this.rng(Rng) is initialized when methods are called, which fix some edge cases when using serialization of WolfCryptRandom objects.JUnit tests have been included for regression prevention.
This fixes a few of the OpenJDK SunJCE DRBG tests.