Fix ECC KeyPairGenerator bits to bytes conversion#157
Merged
rlm2002 merged 1 commit intowolfSSL:masterfrom Sep 15, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the ECC KeyPairGenerator where key sizes specified in bits were incorrectly passed directly to the native wolfSSL library, which expects key sizes in bytes. The fix adds a conversion from bits to bytes for ECC key generation.
- Added bits-to-bytes conversion for ECC key sizes in the initialize method
- Added comprehensive JUnit test to verify the fix works for common ECC key sizes
- Added debug logging to help track ECC key generation parameters
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| WolfCryptKeyPairGenerator.java | Implements the bits-to-bytes conversion for ECC key sizes and adds debug logging |
| WolfCryptKeyPairGeneratorTest.java | Adds regression test to verify ECC key generation with standard bit sizes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/main/java/com/wolfssl/provider/jce/WolfCryptKeyPairGenerator.java
Outdated
Show resolved
Hide resolved
795250a to
111134a
Compare
111134a to
375ab7c
Compare
rlm2002
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes ECC KeyPairGenerator bits to bytes conversion. Java applications pass in key size in bits, but native wolfSSL expects key size in bytes.
JUnit test added for regression prevention.
This fixes OpenJDK SunJCE test:
security/Signature/SignatureLength.java