Additional ECC algorithm OIDs to Signature and KeyPairGenerator#158
Merged
rlm2002 merged 1 commit intowolfSSL:masterfrom Sep 15, 2025
Merged
Additional ECC algorithm OIDs to Signature and KeyPairGenerator#158rlm2002 merged 1 commit intowolfSSL:masterfrom
rlm2002 merged 1 commit intowolfSSL:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds OID (Object Identifier) aliases for ECDSA signature algorithms and EC key pair generation to improve compatibility with OpenJDK SunJCE ECDSA tests. The changes enable the WolfCrypt provider to recognize standard OIDs in addition to algorithm names.
- Adds OID aliases for ECDSA signature algorithms (SHA1, SHA224, SHA256, SHA384, SHA512 with ECDSA)
- Adds OID alias for EC key pair generation
- Includes comprehensive JUnit tests to verify OID-to-algorithm mappings work correctly
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WolfCryptProvider.java | Registers OID aliases for ECDSA signature algorithms and EC key pair generator |
| WolfCryptSignatureTest.java | Adds test to verify ECDSA signature OID mappings work correctly |
| WolfCryptKeyPairGeneratorTest.java | Adds test to verify EC key pair generator OID mapping works correctly |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rlm2002
previously approved these changes
Sep 15, 2025
rlm2002
reviewed
Sep 15, 2025
Contributor
rlm2002
left a comment
There was a problem hiding this comment.
Please resolve merge conflicts.
rlm2002
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds additional ECC algorithm OIDs to
WolfCryptSignatureandWolfCryptKeyPairGenerator.JUnit tests included for regression prevention.
This fixes some of the OpenJDK SunJCE ECDSA tests.