Skip to content

Comments

Additional ECC algorithm OIDs to Signature and KeyPairGenerator#158

Merged
rlm2002 merged 1 commit intowolfSSL:masterfrom
cconlon:eccAlgOids
Sep 15, 2025
Merged

Additional ECC algorithm OIDs to Signature and KeyPairGenerator#158
rlm2002 merged 1 commit intowolfSSL:masterfrom
cconlon:eccAlgOids

Conversation

@cconlon
Copy link
Member

@cconlon cconlon commented Sep 12, 2025

This PR adds additional ECC algorithm OIDs to WolfCryptSignature and WolfCryptKeyPairGenerator.

JUnit tests included for regression prevention.

This fixes some of the OpenJDK SunJCE ECDSA tests.

@cconlon cconlon self-assigned this Sep 12, 2025
@cconlon cconlon requested a review from Copilot September 12, 2025 22:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds OID (Object Identifier) aliases for ECDSA signature algorithms and EC key pair generation to improve compatibility with OpenJDK SunJCE ECDSA tests. The changes enable the WolfCrypt provider to recognize standard OIDs in addition to algorithm names.

  • Adds OID aliases for ECDSA signature algorithms (SHA1, SHA224, SHA256, SHA384, SHA512 with ECDSA)
  • Adds OID alias for EC key pair generation
  • Includes comprehensive JUnit tests to verify OID-to-algorithm mappings work correctly

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
WolfCryptProvider.java Registers OID aliases for ECDSA signature algorithms and EC key pair generator
WolfCryptSignatureTest.java Adds test to verify ECDSA signature OID mappings work correctly
WolfCryptKeyPairGeneratorTest.java Adds test to verify EC key pair generator OID mapping works correctly

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cconlon cconlon assigned rlm2002 and unassigned cconlon Sep 12, 2025
rlm2002
rlm2002 previously approved these changes Sep 15, 2025
Copy link
Contributor

@rlm2002 rlm2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve merge conflicts.

@rlm2002 rlm2002 assigned cconlon and unassigned rlm2002 Sep 15, 2025
@rlm2002 rlm2002 merged commit 69fd49d into wolfSSL:master Sep 15, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants