Remove synchronization on some WolfSSLKeyStore (WKS) methods

[cconlon]

This PR removes synchronized from some of the WolfSSLKeyStore methods that do not need the full method to be synchronized. ConcurrentHashMap is already used internally to store entries, which is thread safe.

Write/set methods maintain synchronization, and SecureRandom is already protected by randLock.

One JUnit test is added here, to test concurrent access to engineGetCertificateAlias().

ZD 20754

[Copilot]

Pull Request Overview

This PR removes the synchronized keyword from 10 read-only methods in the WolfSSLKeyStore class to improve concurrency performance. Since the underlying entries field is a ConcurrentHashMap, these methods can safely be accessed concurrently without explicit synchronization.

• Removed synchronized from all getter methods that only read from the ConcurrentHashMap
• Methods that modify state remain synchronized to ensure proper coordination of writes
• Enables better concurrent read performance for multi-threaded applications

Comments suppressed due to low confidence (1)

src/main/java/com/wolfssl/provider/jce/WolfSSLKeyStore.java:1282

• The removal of synchronized from engineGetCertificateAlias lacks test coverage for concurrent access patterns. The existing threaded test (testStoreToByteArrayThreaded) creates separate KeyStore instances per thread, so it doesn't verify behavior when multiple threads simultaneously read from and write to the same KeyStore instance. Consider adding a test that verifies engineGetCertificateAlias returns correct results when called concurrently with engineSetKeyEntry or engineSetCertificateEntry on the same KeyStore instance.

    public String engineGetCertificateAlias(Certificate cert) {

        Certificate tmp = null;

        if (cert == null) {
            return null;
        }

        for (Map.Entry<String, Object> entry : entries.entrySet()) {
            if (entry.getValue() instanceof WKSCertificate) {
                tmp = ((WKSCertificate)entry.getValue()).cert;
            }
            else if ((entry.getValue() instanceof WKSPrivateKey) &&
                     (((WKSPrivateKey)entry.getValue()).chain != null)) {
                tmp = ((WKSPrivateKey)entry.getValue()).chain[0];
            }

            if ((tmp != null) && tmp.equals(cert)) {
                return entry.getKey();
            }
        }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.