Skip to content

add sanity check for Windows terminal resize #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejohnstown merged 2 commits into from
Jan 10, 2026
+10 −4
Merged

add sanity check for Windows terminal resize #864

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adcb7e1
add sanity check for Windows terminal resize
JacobBarthelmeh Jan 6, 2026
9097542
use sizeof for getting the command buffer size
JacobBarthelmeh Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/internal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,16 +1096,22 @@ static int WS_TermResize(WOLFSSH* ssh, word32 col, word32 row, word32 colP,
int ret = WS_SUCCESS;

if (term != NULL) {
char cmd[20];
int cmdSz = 20;
char cmd[30]; /* 2 int values (11 chars max) plus \x1b[8 ; t */
int cmdSz;
DWORD wrtn = 0;

cmdSz = (int)sizeof(cmd);
/* VT control sequence for resizing window */
cmdSz = snprintf(cmd, cmdSz, "\x1b[8;%d;%dt", row, col);
if (WriteFile(*term, cmd, cmdSz, &wrtn, 0) != TRUE) {
WLOG(WS_LOG_ERROR, "Issue with pseudo console resize");
if (cmdSz < 0 || cmdSz >= sizeof(cmd)) {
ret = WS_FATAL_ERROR;
}
else {
if (WriteFile(*term, cmd, cmdSz, &wrtn, 0) != TRUE) {
WLOG(WS_LOG_ERROR, "Issue with pseudo console resize");
ret = WS_FATAL_ERROR;
}
}
}

return ret;
Expand Down