Fix Test Term Size #868
Fix Test Term Size #868
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where running build tests causes the terminal size to be set to 0x0, resulting in terminal applications like vim misbehaving until the terminal window is manually resized. The fix prevents terminal size changes when the echoserver is running in echo mode.
Changes:
- Added conditional check to skip terminal size operations in echo mode
- Moved
wolfSSH_DoModes()call inside the conditional block - Updated comment to clarify the behavior applies only when not echoing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ejohnstown
force-pushed
the
fix-test-term-size
branch
3 times, most recently
from
9fc2192 to
72e6c26
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When running the build tests, the terminal size gets set to 0x0. When then tests finish, things like vim start to misbehave until you change your term window size. 1. Echoserver will not change the terminal size when in echo mode. 2. Do not update the modes when the echo server is not in echo mode. 3. Do not set the terminal update callback context when the echo server is not in echo mode. 4. Update the guards around the above three items to match the guards for the modes update function.
ejohnstown
force-pushed
the
fix-test-term-size
branch
from
72e6c26 to
78e3899
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
When running the build tests, the terminal size gets set to 0x0. When then tests finish, things like vim start to misbehave until you change your term window size. Do not set the terminal size when running the echoserver in echo mode.