Avoid flexible arrays on unsupported platforms via a macro. #7538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
requested changes
May 15, 2024
| #pragma warning(disable: 4200) | ||
| #endif | ||
| byte hashSigAlgo[]; /* sig/algo to offer */ | ||
| byte hashSigAlgo[WOLFSSL_FLEXIBLE_ARRAY_SIZE]; /* sig/algo to offer */ |
Contributor
There was a problem hiding this comment.
[clang-tidy-defaults] [7 of 7] [ac3063c1e8]
configure... real 0m18.881s user 0m5.668s sys 0m2.801s
build..../wolfssl/internal.h:3178:29: warning: zero size arrays are an extension [clang-diagnostic-zero-length-array]
byte hashSigAlgo[WOLFSSL_FLEXIBLE_ARRAY_SIZE]; /* sig/algo to offer */
^
/tmp/workspace/PRB-multi-test-script/wolfssl/./wolfssl/wolfcrypt/wc_port.h:1276:41: note: expanded from macro 'WOLFSSL_FLEXIBLE_ARRAY_SIZE'
#define WOLFSSL_FLEXIBLE_ARRAY_SIZE 0
^
./wolfssl/internal.h:3356:17: warning: zero size arrays are an extension [clang-diagnostic-zero-length-array]
byte data[WOLFSSL_FLEXIBLE_ARRAY_SIZE];
^
/tmp/workspace/PRB-multi-test-script/wolfssl/./wolfssl/wolfcrypt/wc_port.h:1276:41: note: expanded from macro 'WOLFSSL_FLEXIBLE_ARRAY_SIZE'
#define WOLFSSL_FLEXIBLE_ARRAY_SIZE 0
^
./wolfssl/internal.h:5216:14: warning: zero size arrays are an extension [clang-diagnostic-zero-length-array]
byte buf[WOLFSSL_FLEXIBLE_ARRAY_SIZE];
^
/tmp/workspace/PRB-multi-test-script/wolfssl/./wolfssl/wolfcrypt/wc_port.h:1276:41: note: expanded from macro 'WOLFSSL_FLEXIBLE_ARRAY_SIZE'
#define WOLFSSL_FLEXIBLE_ARRAY_SIZE 0
^
make[2]: *** [Makefile:7277: wolfcrypt/src/src_libwolfssl_la-asn.lo] Error 1
make[1]: *** [Makefile:8414: all-recursive] Error 1
make: *** [Makefile:5059: all] Error 2
real 2m34.598s user 2m0.813s sys 0m2.866s
clang-tidy-defaults fail_analytic_build
failed config: 'CPPFLAGS=-DKEEP_OUR_CERT -DKEEP_PEER_CERT -DWOLFSSL_ALT_NAMES -DNO_WOLFSSL_CIPHER_SUITE_TEST -DWOLFSSL_OLD_PRIME_CHECK -pedantic -DSP_ALLOC -DWOLFSSL_CLANG_TIDY' 'CC=/tmp/workspace/PRB-multi-test-script/testing/git-hooks/clang-tidy-builder.sh' 'CLANG=/usr/lib/llvm-14/bin/clang-14' 'CFLAGS=-Wunreachable-code-aggressive -Wthread-safety -Wloop-analysis -Wenum-compare-conditional -fcolor-diagnostics -fcomplete-member-pointers -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -g -fdebug-types-section -Wunreachable-code-break -Wunreachable-code-return -Wimplicit-fallthrough'
final tally: 6 of 7 checks succeeded, 0 skipped, 0 forced, and 1 failed, for ac3063c1e8.
exiting with status 2
kareem-wolfssl
force-pushed
the
zd17977
branch
from
d4da6f8 to
f4293d9
Compare
douzzer
requested changes
Nov 16, 2024
Contributor
douzzer
left a comment
douzzer
left a comment
There was a problem hiding this comment.
sync with latest from wolfSentry.
wolfssl/wolfcrypt/wc_port.h
Outdated
Comment on lines
1378
to
1386
| #if defined(__STRICT_ANSI__) | ||
| #define WOLFSSL_FLEXIBLE_ARRAY_SIZE 1 | ||
| #elif defined(__GNUC__) | ||
| #define WOLFSSL_FLEXIBLE_ARRAY_SIZE | ||
| /*!< \brief Value appropriate as a size for an array that will be allocated to a variable size. Built-in value usually works. */ | ||
| #else | ||
| #define WOLFSSL_FLEXIBLE_ARRAY_SIZE 0 | ||
| #endif | ||
|
|
Contributor
There was a problem hiding this comment.
The latest setup from wolfSentry has more subtleties.
Thanks to wolfSentry for the logic.
kareem-wolfssl
force-pushed
the
zd17977
branch
from
498c63f to
b399fd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#17977
Credit to wolfSentry for the fix
Customer to confirm fix, please do not merge before then
Testing
Built in tests with --enable-dtlscid --enable-tls13 --enable-tlsx --enable-dtls13 --enable-dtls which should cover all cases
Checklist