Skip to content

ARM32/Thumb2/RISC-V 64 ASM: omit frame pointer#8893

Merged
dgarske merged 1 commit intowolfSSL:masterfrom
SparkiDev:asm_omit_frame_pointer
Jun 19, 2025
Merged

ARM32/Thumb2/RISC-V 64 ASM: omit frame pointer#8893
dgarske merged 1 commit intowolfSSL:masterfrom
SparkiDev:asm_omit_frame_pointer

Conversation

@SparkiDev
Copy link
Contributor

@SparkiDev SparkiDev commented Jun 18, 2025

Description

ARM32/Thumb2: Generated code now omits the frame pointer attribute on each function. Remove global use in configure.ac.
RISC-V 64: Omit the frame pointer on the one function that uses the register 's0'.

Fixes zd#20080

Testing

Tested all inline ARM32/Thumb2/RISC-V 64 assembly.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

ARM32/Thumb2: Generated code now omits the frame pointer attribute on
each function. Remove global use in configure.ac.
RISC-V 64: Omit the frame pointer on the one function that uses the
register 's0'.
@SparkiDev SparkiDev self-assigned this Jun 18, 2025
@SparkiDev
Copy link
Contributor Author

retest this please

@SparkiDev SparkiDev assigned wolfSSL-Bot and anhu and unassigned SparkiDev Jun 18, 2025
@SparkiDev SparkiDev requested a review from wolfSSL-Bot June 18, 2025 02:41
@dgarske dgarske assigned dgarske and unassigned anhu Jun 18, 2025
@dgarske
Copy link
Contributor

dgarske commented Jun 18, 2025

I am going to test this on Cortex-M as well, since in debug mode we were getting the r7 conflict and this might be a good solution for that as well. I posted a comment to customer in ZD20080.

Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful improvement! Resolves the issue with having to set in debug builds on Cortex-M7. Love it! Thank you Sean

@dgarske dgarske merged commit 7610b4e into wolfSSL:master Jun 19, 2025
273 of 274 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants