Disable MD5 by default

[AlexLanzano]

Description

Disable the use of MD5 by default.
Add the conditional use of MD5 when --enable-all-crypto or --enable-all is present.
Add the use of MD5 when --enable-opensslextra is present.
Add the use of MD5 when --enable-tlsv10 is present.

Testing

Here are the following configure commands I tested:

Test 1:

./configure

This produces a configure output indicating MD5 is disabled as expected.

Test 2:

./configure --enable-all

and

./configure --enable-all-crypto

Both produce a configure output indicating MD5 is enabled as expected.

Test 3:

./configure --enable-all --disable-md5

and

./configure --enable-all-crypto --disable-md5

Both produce a configure output indicating MD5 is disabled as expected.

Test 4:

./configure --enable-tlsv10

This produced a configure output indicating MD5 is enabled as expected.

[dgarske]

Assigning back to you @AlexLanzano since there are many failing tests. All related to the compatibility layer enables for OSP projects...

[AlexLanzano]

Retest this please

It seems the libspm test is failing due to https://git.cryptomilk.org/projects/cmocka.git/ being down

The Ubuntu-Macos-Windows test fails on macos-latest when configuring with user_settings.h. Im unable to reproduce this error on my macbook when doing the same steps. Possibly a fluke?

[AlexLanzano]

Retest this please.

Does not look like the tests were rerun from my first prompt.

[dgarske]

Retest this please. Cannot get history for these, but commonly fail and report agent offline

• Build PRB-generic-config-parser completed: FAILURE
• Build wolfSSL » PRB-fips-repo-and-harness-test-v3-part1 completed: FAILURE

[dgarske]

A test is failing still:

--enable-bump --enable-sni --enable-renegotiation-indication --enable-sha512 --enable-ecc --enable-supportedcurves

ERROR - tests/api.c line 53740 failed with:
    expected: wolfSSL_PEM_write_mem_RSAPrivateKey(rsa, wolfSSL_EVP_aes_128_cbc(), passwd, sizeof(passwd) - 1, &pem, &plen) == 1
    result:   0 != 1
 failed (  0.00005)
ERROR - tests/api.c line 68805 failed with:

[dgarske]

Disabling MD5 by default is a big job! Lol

Failures in single flag tests 25,70, 80, 85

--enable-lighty

Still seeing FAILURES:
740: test_wolfSSL_PKCS8_d2i
861: test_wolfSSL_PEM_write_RSAPrivateKey
862: test_wolfSSL_PEM_write_mem_RSAPrivateKey

--enable-mcapi --with-libz

mcapi/mcapi_test.c: In function ‘check_md5’:
mcapi/mcapi_test.c:223:5: error: unknown type name ‘Md5’
  223 |     Md5           defMd5;
      |     ^~~

[AlexLanzano]

Retest this please.

Unable to reproduce the failure in "Known apple M1 customer configs A". Maybe a connection issue?

Not seeing some output from PRB-master-job on PRB-generic-config-parser #9216

[JacobBarthelmeh]

Retest this please Jenkins (updated test cases for recently added tests)

Fixed