Skip to content

Entropy: fix proportion health test #8899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaleb-himes merged 1 commit into from
Jun 20, 2025
Merged

Entropy: fix proportion health test #8899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions wolfcrypt/src/random.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1342,6 +1342,8 @@ static int Entropy_HealthTest_Proportion(byte noise)
prop_last = (prop_last + 1) % PROP_WINDOW_SIZE;
/* Added sample to queue - add count. */
prop_cnt[noise]++;
/* Update count of store values. */
prop_total++;

/* Check whether first value has too many repetitions in queue. */
if (prop_cnt[noise] >= PROP_CUTOFF) {
Expand All @@ -1360,6 +1362,8 @@ static int Entropy_HealthTest_Proportion(byte noise)
prop_first = (prop_first + 1) % PROP_WINDOW_SIZE;
/* Removed first sample from queue - remove count. */
prop_cnt[val]--;
/* Update count of store values. */
prop_total--;
}
}

Expand Down