tls ocsp: support lazy cert loading with ocsp stapling #9144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julek-wolfssl
force-pushed
the
ocsp-callbacks
branch
7 times, most recently
from
93e9ce1 to
a3a2ba8
Compare
Contributor
|
I like the changes. |
julek-wolfssl
force-pushed
the
ocsp-callbacks
branch
5 times, most recently
from
3f513f7 to
581e50e
Compare
Contributor
|
🛟 Devin Lifeguard found 1 likely issues in this PR
@julek-wolfssl |
julek-wolfssl
force-pushed
the
ocsp-callbacks
branch
from
581e50e to
90efade
Compare
Member
Author
|
Devin is wrong. |
julek-wolfssl
force-pushed
the
ocsp-callbacks
branch
from
90efade to
2e1b479
Compare
julek-wolfssl
changed the title
julek-wolfssl
changed the title
julek-wolfssl
force-pushed
the
ocsp-callbacks
branch
6 times, most recently
from
f42333b to
15bb03a
Compare
julek-wolfssl
commented
Sep 16, 2025
Member
Author
julek-wolfssl
left a comment
julek-wolfssl
left a comment
There was a problem hiding this comment.
TODO
- Add docs once we settle on the new API
julek-wolfssl
force-pushed
the
ocsp-callbacks
branch
from
a82fde9 to
8b039b0
Compare
rizlik
requested changes
Sep 30, 2025
rizlik
previously approved these changes
Sep 30, 2025
Contributor
|
Jenkins retest this please: "AgentOfflineException" |
julek-wolfssl
force-pushed
the
ocsp-callbacks
branch
from
bb5b53d to
6cc35f8
Compare
Member
Author
|
Retest this please RequestAbortedException AgentOfflineException |
julek-wolfssl
force-pushed
the
ocsp-callbacks
branch
from
6cc35f8 to
1d11cfa
Compare
Member
Author
|
Espressif failure not relevant and Jenkins keeps crashing. |
Contributor
|
Jenkins retest this please. Fips test was aborted. |
dgarske
requested changes
Oct 2, 2025
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Looks good otherwise! Thank you
Contributor
|
@julek-wolfssl Please rebase and squash too with your next push. Thank you |
julek-wolfssl
force-pushed
the
ocsp-callbacks
branch
from
1d11cfa to
fb51e04
Compare
Exposes dynamic TLS certificate loading and OCSP stapling to allow applications to load certs lazily. The server no longer needs to load the CA to staple OCSP responses. Adds a certificate setup callback (WOLFSSL_CERT_SETUP_CB) Adds an OCSP status callback to load OCSP responses directly Adds `wc_NewOCSP`, `wc_FreeOCSP`, and `wc_CheckCertOcspResponse` Don't call verify twice on the same error Send correct alert on status response error
julek-wolfssl
force-pushed
the
ocsp-callbacks
branch
from
fb51e04 to
f9063c4
Compare
Member
Author
|
Retest this please RequestAbortedException AgentOfflineException |
dgarske
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wc_InitOCSP,wc_FreeOCSP, andwc_CheckCertOcspResponseas wrapper functions around existing OCSP functionalityCo-Authored-By: Marco Oliverio [email protected]