address undefined shift behavior and overflow#9195
Merged
JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom Sep 18, 2025
Merged
address undefined shift behavior and overflow#9195JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom
JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom
Conversation
Contributor
Author
|
Retest this please jenkins: StreamCorruptedException |
SparkiDev
requested changes
Sep 15, 2025
rlm2002
force-pushed
the
zd20508
branch
3 times, most recently
from
ca1665b to
01b2177
Compare
Contributor
Author
|
Retest this please jenkins: generic config parser was not stable |
SparkiDev
approved these changes
Sep 17, 2025
JacobBarthelmeh
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
address undefined shift behavior and overflow in
pwdbased.c. Cast1 << cost * bSzto avoid 32-bit overflow. Reject parameter combinations where (1 << cost) * bSz would exceed SCRYPT_WORD32_MAX.Add test case for
cost = 22andblockSize = 8address zd#20508
Shoutout to Luigino Camastra, Aisle Research for the report. Thank you!
Testing
./configure --enable-scrypt --enable-opensslextra && make checkChecklist