Skip to content

refactor to BuildMsgOrHashOutput()#9200

Merged
SparkiDev merged 1 commit intowolfSSL:masterfrom
effbiae:build-msg-or-hash-output
Oct 6, 2025
Merged

refactor to BuildMsgOrHashOutput()#9200
SparkiDev merged 1 commit intowolfSSL:masterfrom
effbiae:build-msg-or-hash-output

Conversation

@effbiae
Copy link
Contributor

@effbiae effbiae commented Sep 16, 2025 •
edited
Loading

Description

this patch pulls a pattern out of src/internal.c and replaces it with a function:

-        if (IsEncryptionOn(ssl, 1)) {
-               ...
-               BuildMessage(ssl, output, sendSz, ...
-               ...
-         else
-               ...
-               HashOutput(ssl, output,...
-               ...

+        BuildMsgOrHashOutput(ssl, output,...

Testing

./autogen.sh && ./configure && make check && \
./configure --enable-all && make check && \
./configure --enable-all --enable-opensslextra && make check && \
./configure --enable-all --enable-secure-renegotiation && make check

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@wolfSSL-Bot
Copy link

wolfSSL-Bot commented Sep 16, 2025

Can one of the admins verify this patch?

@dgarske
Copy link
Contributor

dgarske commented Sep 26, 2025

Okay to test

@effbiae effbiae force-pushed the build-msg-or-hash-output branch from 2c35721 to b67e50f Compare September 28, 2025 06:54
dgarske
dgarske requested changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a nice cleanup! This does have some failed tests: https://github.com/wolfSSL/wolfssl/actions/runs/18070780816/job/51743666928?pr=9200

@dgarske dgarske assigned effbiae and unassigned dgarske Oct 1, 2025
@effbiae effbiae force-pushed the build-msg-or-hash-output branch from b67e50f to b8ba694 Compare October 2, 2025 05:31
@effbiae
Copy link
Contributor Author

effbiae commented Oct 2, 2025

what happened in PRB-master-job?

@dgarske
Copy link
Contributor

dgarske commented Oct 2, 2025

Jenkins retest this please. Tests aborted.

dgarske
dgarske requested changes Oct 2, 2025
View reviewed changes
@effbiae effbiae force-pushed the build-msg-or-hash-output branch from b8ba694 to 2adae90 Compare October 3, 2025 01:42
@effbiae
Copy link
Contributor Author

effbiae commented Oct 3, 2025

the usual macos fails with "connection refused"
don't know about the rng-tools failure

@dgarske
Copy link
Contributor

dgarske commented Oct 3, 2025

Jenkins retest this please: "AgentOfflineException"

@dgarske dgarske assigned SparkiDev and unassigned effbiae Oct 3, 2025
@dgarske dgarske requested a review from SparkiDev October 3, 2025 16:19
@dgarske
Copy link
Contributor

dgarske commented Oct 3, 2025

Jenkins retest this please: Generic config aborted. Internet outage?

@SparkiDev SparkiDev merged commit 9d546ac into wolfSSL:master Oct 6, 2025
330 of 334 checks passed
@effbiae effbiae deleted the build-msg-or-hash-output branch October 7, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgarske dgarske dgarske approved these changes

@SparkiDev SparkiDev SparkiDev approved these changes

Assignees

@wolfSSL-Bot wolfSSL-Bot

@SparkiDev SparkiDev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@effbiae @wolfSSL-Bot @dgarske @SparkiDev