Prevent replaying ClientHello messages when Finished message are epoch 0 #9205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasbytes
force-pushed
the
issue-9188
branch
from
d702709 to
f9f8373
Compare
gasbytes
force-pushed
the
issue-9188
branch
from
f9f8373 to
ec335cd
Compare
Contributor
Author
|
Jenkins retest this please For AgentOfflineException: Unable to create live FilePath for wolf-linux-cloud-node-[n]; wolf-linux-cloud-node-[n] was marked offline: Connection was broken |
JacobBarthelmeh
previously approved these changes
Sep 17, 2025
Contributor
JacobBarthelmeh
left a comment
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Looks good.
@julek-wolfssl please also review, and merge if passing review. Thanks.
julek-wolfssl
requested changes
Sep 17, 2025
gasbytes
force-pushed
the
issue-9188
branch
from
ec335cd to
4c94653
Compare
messages when receiving bogus Finished messages in epoch 0 by ensuring Finished messages are only ignored in encrypted epochs (1).
gasbytes
force-pushed
the
issue-9188
branch
from
4c94653 to
8f47b4b
Compare
Contributor
Author
|
Jenkins retest this please For AgentOfflineException: Unable to create live FilePath for wolf-linux-cloud-node-[n]; wolf-linux-cloud-node-[n] was marked offline: Connection was broken |
julek-wolfssl
requested changes
Sep 22, 2025
Contributor
Author
|
Jenkins retest this please For AgentOfflineException: Unable to create live FilePath for wolf-linux-cloud-node-[n]; wolf-linux-cloud-node-[n] was marked offline: Connection was broken |
julek-wolfssl
approved these changes
Sep 22, 2025
douzzer
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent DTLS clients from replaying ClientHello messages when receiving bogus Finished messages in epoch 0 by ensuring Finished messages are only ignored in encrypted epochs (1).
Testing
Added test case named
test_dtls_bogus_finished_epoch_zeroin the file tests/api/test_dtls.c.configuration:
AM_CFLAGS='-DHAVE_AES_CBC -DWOLFSSL_AES_128 -DWOLFSSL_DEBUG_TLS' ./configure --enable-dtls --enable-dtls13 --enable-keylog-export --enable-psk --enable-rsa --enable-sha --enable-debug C_EXTRA_FLAGS=-DWOLFSSL_STATIC_PSKissue can be seen by running the client like so:
examples/client/client -i -x -p ${some_port} -s -u -l PSK-AES128-CBC-SHA256Addresses: #9188
Checklist