-
Notifications
You must be signed in to change notification settings - Fork 916
restore inner server name in TLSX_WriteWithEch #9234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🛟 Devin Lifeguard found 1 likely issues in this PR
@effbiae |
|
Can one of the admins verify this patch? |
|
Okay to test |
|
retest this please |
|
Jenkins retest this please: "AgentOfflineException" |
dgarske
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good. Can you provide details on how you discovered this issue?
|
I have a tool that finds copy and pasted code and it found this area in the
code. I discovered the problem reading the code.
…On Thu, 2 Oct 2025, 7:39 am David Garske, ***@***.***> wrote:
***@***.**** approved this pull request.
This change looks good. Can you provide details on how you discovered this
issue?
—
Reply to this email directly, view it on GitHub
<#9234 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE74H2KQGA3OCHOABYXXN33VRC2PAVCNFSM6AAAAACHIWRP36VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTEOJRGIZTIOBQGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Cool! Are you able to tell us the name of the tool? |
|
yes, "PMD" eg. $ pmd cpd -l cpp src/* --minimum-tokens=100
…On Thu, 2 Oct 2025 at 10:27, David Garske ***@***.***> wrote:
*dgarske* left a comment (wolfSSL/wolfssl#9234)
<#9234 (comment)>
I have a tool that finds copy and pasted code and it found this area in
the code. I discovered the problem reading the code.
… <#m_-9014388764136641610_>
On Thu, 2 Oct 2025, 7:39 am David Garske, *@*.*> wrote: @.** approved
this pull request. This change looks good. Can you provide details on how
you discovered this issue? — Reply to this email directly, view it on
GitHub <#9234 (review)
<#9234 (review)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE74H2KQGA3OCHOABYXXN33VRC2PAVCNFSM6AAAAACHIWRP36VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTEOJRGIZTIOBQGM
. You are receiving this because you were mentioned.Message ID: *@*.***>
Cool! Are you able to tell us the name of the tool?
—
Reply to this email directly, view it on GitHub
<#9234 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE74HYN5JVRPAHHPUCTRLL3VRWPDAVCNFSM6AAAAACHIWRP36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNJYGYYDMMJZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Description
this patch restores the inner server name even if the write didn't have a shot at acceptance
Testing
./configure && make check && ./configure --enable-all && make checkChecklist