Skip to content

Conversation

@effbiae
Copy link
Contributor

@effbiae effbiae commented Sep 23, 2025

Description

this patch restores the inner server name even if the write didn't have a shot at acceptance

Testing

./configure && make check && ./configure --enable-all && make check

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@devin-ai-integration
Copy link
Contributor

🛟 Devin Lifeguard found 1 likely issues in this PR

  • check-all-return-codes snippet: Assign TLSX_Remove’s return value to a variable (e.g., r2) and, if ret is still 0, propagate an error when r2 != WOLFSSL_SUCCESS.

@effbiae
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@dgarske
Copy link
Contributor

dgarske commented Sep 26, 2025

Okay to test

@douzzer
Copy link
Contributor

douzzer commented Sep 30, 2025

retest this please

@dgarske
Copy link
Contributor

dgarske commented Oct 1, 2025

Jenkins retest this please: "AgentOfflineException"

Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good. Can you provide details on how you discovered this issue?

@dgarske dgarske removed their assignment Oct 1, 2025
@effbiae
Copy link
Contributor Author

effbiae commented Oct 1, 2025 via email

@dgarske
Copy link
Contributor

dgarske commented Oct 2, 2025

I have a tool that finds copy and pasted code and it found this area in the code. I discovered the problem reading the code.

On Thu, 2 Oct 2025, 7:39 am David Garske, @.> wrote: @.* approved this pull request. This change looks good. Can you provide details on how you discovered this issue? — Reply to this email directly, view it on GitHub <#9234 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE74H2KQGA3OCHOABYXXN33VRC2PAVCNFSM6AAAAACHIWRP36VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTEOJRGIZTIOBQGM . You are receiving this because you were mentioned.Message ID: @.***>

Cool! Are you able to tell us the name of the tool?

@effbiae
Copy link
Contributor Author

effbiae commented Oct 2, 2025 via email

@SparkiDev SparkiDev merged commit ea4554c into wolfSSL:master Oct 2, 2025
252 checks passed
@effbiae effbiae deleted the TLSX_WriteWithEch branch October 7, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants