Enable actual ecc key pair validation by default. #9241
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This would have prevented ZD20564 |
douzzer
requested changes
Sep 24, 2025
wolfssl/wolfcrypt/settings.h
Outdated
| #undef HAVE_ECC_KEY_EXPORT | ||
| #define HAVE_ECC_KEY_EXPORT | ||
| #endif | ||
| #ifndef WOLFSSL_NO_VALIDATE_ECC_IMPORT |
Contributor
There was a problem hiding this comment.
needs to be
#if !defined(WOLFSSL_NO_VALIDATE_ECC_IMPORT) && \
!defined(WOLFSSL_VALIDATE_ECC_IMPORT)
to avoid error: ... redefined.
You may also want to add
#elif defined(WOLFSSL_NO_VALIDATE_ECC_IMPORT) && \
defined(WOLFSSL_VALIDATE_ECC_IMPORT)
#error Conflicting settings for WOLFSSL_VALIDATE_ECC_IMPORT.
anhu
force-pushed
the
ecc_validate_by_default
branch
from
7b8667c to
360f24d
Compare
anhu
force-pushed
the
ecc_validate_by_default
branch
from
360f24d to
9030c6c
Compare
Member
Author
|
Doing this check at TLS connection time is not a practical thing to do. Expensive. Lets not do this by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.