TLS 1.3 Cookie Hash: use stronger hash if no SHA-256 #9255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
tls13_cookie_hash
branch
2 times, most recently
from
39782ef to
b048acb
Compare
Contributor
Author
|
retest this please Unable to create live FilePath for wolf-linux-cloud-node-j9hb60; wolf-linux-cloud-node-j9hb60 was marked offline: Connection was broken |
SparkiDev
force-pushed
the
tls13_cookie_hash
branch
from
b048acb to
dffdff0
Compare
Order of preference, based on algorithms compiled in, to use with HMAC for TLS 1.3 cookie: 1. SHA-256 2. SHA-384 3. SHA-512 4. SM3 Make code compile and unittest pass when SHA-256 not compiled in. Certificates used for testing require SHA-256 so handshake testing fails.
SparkiDev
force-pushed
the
tls13_cookie_hash
branch
from
dffdff0 to
e14cc3a
Compare
Contributor
Author
|
retest this please hudson.remoting.Channel$CallSiteStackTrace: Remote call to boz-amd |
dgarske
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Order of preference, based on algorithms compiled in, to use with HMAC for TLS 1.3 cookie:
Make code compile and unittest pass when SHA-256 not compiled in. Certificates used for testing require SHA-256 so handshake testing fails.
Fixes zd#20505
Testing
How did you test?
Checklist