Skip to content

Conversation

@danielinux
Copy link
Member

@danielinux danielinux commented Oct 7, 2025

Description

Add support for AES_CTR via wc_pkcs11.c

Proposed fix for zd#20548

Testing

interop test suite within wolfPKCS11

@danielinux danielinux requested a review from LinuxJedi October 7, 2025 11:07
@devin-ai-integration
Copy link
Contributor

🛟 Devin Lifeguard found 1 likely issues in this PR

  • limit-stack-usage snippet snippet: Measure sizeof(CK_MECHANISM_INFO), CK_AES_CTR_PARAMS, and CK_MECHANISM for the target platforms; if the combined locals exceed 100 bytes, apply the WOLFSSL_SMALL_STACK pattern (e.g., allocate the three large structs with XMALLOC and free them before return).

@danielinux
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

@dgarske
Copy link
Contributor

dgarske commented Oct 7, 2025

Jenkins retest this please. Generic DTLS config "FAIL scripts/openssl.test (exit status: 1)"

@danielinux danielinux requested review from wolfSSL-Bot and removed request for LinuxJedi October 7, 2025 14:40
@danielinux danielinux removed the request for review from wolfSSL-Bot October 7, 2025 14:41
@dgarske
Copy link
Contributor

dgarske commented Oct 7, 2025

Jenkins retest this please: "FIPSv2-regression"

Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over to @SparkiDev to finalize.

@danielinux
Copy link
Member Author

tested via wolfSSL/wolfPKCS11#148

@dgarske dgarske merged commit 7c64292 into wolfSSL:master Oct 8, 2025
341 of 344 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants