-
Notifications
You must be signed in to change notification settings - Fork 920
AES: Improve CFB and OFB and add tests #9315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🛟 Devin Lifeguard found 2 likely issues in this PR
@SparkiDev |
dc8670a to
16aa1fc
Compare
|
Small stack respected in new test_aes.c code. |
7b02d27 to
dcec9e0
Compare
dcec9e0 to
e710575
Compare
dgarske
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I resolved the merge conflict and approve.
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements! I have a minor concern about pervious ports working with the additional sanity check though.
e710575 to
0f00632
Compare
0f00632 to
6a91447
Compare
|
Removed check and removed tests for NULL. |
Improve performance of CFB and OFB. Only have one implementation that is used by OFB encrypt and decrypt. Update AES testing in unit.test. Update benchmarking of CFB and OFb to include decrypt.
6a91447 to
8533bc8
Compare
Description
Improve performance of CFB and OFB.
Only have one implementation that is used by OFB encrypt and decrypt.
Update AES testing in unit.test.
Update benchmarking of CFB and OFb to include decrypt.
Testing
Regression tested AES.
Checklist