20251024-fixes #9344
Merged
20251024-fixes #9344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix gating on wolfCrypt_FIPS_AES_sanity (always gate in for FIPS v7+); wolfcrypt/src/port/af_alg/afalg_aes.c: check for null key arg; configure.ac: rename BUILD_FIPS_CURRENT to BUILD_FIPS_V2_PLUS (no functional change), and remove unused ARMASM_DIST_SOURCES set up code added in wolfSSL#9332; src/include.am: * set up $(ARMASM_SHA256_C), and use it to properly include wolfcrypt/src/sha256.c alongside armasm when appropriate; * fix gating on Curved25519 armasm (BUILD_FIPS_V6_PLUS, not BUILD_FIPS_V6); tests/api/test_aes.c and wolfcrypt/test/test.c: gate out incompatible coverage for WOLFSSL_AFALG and WOLFSSL_KCAPI (test_wc_AesCbcEncryptDecrypt_MultiBlocks(), test_wc_AesCtrSetKey*(), test_wc_AesCtrEncrypt*(), test_wc_AesGcmEncryptDecrypt_Sizes()).
dgarske
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wolfcrypt/src/aes.c: defineGCM_GMULT_LEN()whenWOLFSSL_ARMASM, and fix gating onwolfCrypt_FIPS_AES_sanity(always gate in for FIPS v7+);wolfcrypt/src/port/af_alg/afalg_aes.c: check for null key arg;configure.ac: renameBUILD_FIPS_CURRENTtoBUILD_FIPS_V2_PLUS(no functional change), and remove unusedARMASM_DIST_SOURCESset up code added in #9332;src/include.am:$(ARMASM_SHA256_C), and use it to properly includewolfcrypt/src/sha256.calongside armasm when appropriate;BUILD_FIPS_V6_PLUS, notBUILD_FIPS_V6);tests/api/test_aes.candwolfcrypt/test/test.c: gate out incompatible coverage forWOLFSSL_AFALGandWOLFSSL_KCAPI(test_wc_AesCbcEncryptDecrypt_MultiBlocks(),test_wc_AesCtrSetKey*(),test_wc_AesCtrEncrypt*(),test_wc_AesGcmEncryptDecrypt_Sizes()).tested with