Fix PKCS#7 SignedData parsing for non-OCTET_STRING content types #9559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
wolfSSL failed to parse PKCS#7 SignedData bundles where the encapsulated content was a
SEQUENCE(per PKCS#7 "ANY" type) rather thanOCTET_STRING(per CMS spec). This affected parsing of Microsoft Authenticode signatures.This PR fixes the issue by correctly setting the content size for non OCTET_STRING encapsulated contents. It also fixes a degenerate bundle detection issue that showed up when testing the primary issue.
Testing
Tested by building a reproducer based on Issue #9213, then creating a unit test that reproduced the same issue (included here in tests/api/test_pkcs7.c).
Checklist