Merged
Conversation
Contributor
|
🛟 Devin Lifeguard found 2 likely issues in this PR
@SparkiDev |
bb2a5a6 to
9ef16e8
Compare
9ef16e8 to
754b03a
Compare
Add non-constant time implemenations of mod_inv for x64 and Aarch64 assembly. Generate base point table, with better formatting, for double smul with a script. Increase Bi table size to 32 entries for 64-bit asm. Minor improvements to double smul. WOLFSSL_CURVE25519_NOT_USE_ED25519 to not use ed25519 base smul in curve25519 base smul.
754b03a to
3824122
Compare
Contributor
Author
|
retest this please |
dgarske
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add non-constant time implemenations of mod_inv for x64 and Aarch64 assembly.
Generate base point table, with better formatting, for double smul with a script.
Increase Bi table size to 32 entries for 64-bit asm. Minor improvements to double smul.
WOLFSSL_CURVE25519_NOT_USE_ED25519 to not use ed25519 base smul in curve25519 base smul.
Testing
Tested multiple Curve25519 and Ed25519 configurations.
Checklist