20251230-persistent-drbg

[douzzer]

wolfcrypt/src/random.c and wolfssl/wolfcrypt/random.h: implement WC_RNG_BANK_SUPPORT:

• add WC_DRBG_BANKREF status code;
• add struct wc_rng_bank *bankref to struct WC_RNG, and move status slot out from HAVE_HASHDRBG gate;
• add WC_DRBG_MAX_SALT_SZ, and add saltSz and salt slots to struct DRBG_internal;
• add salt handling to Hash_df(), Hash_DRBG_Instantiate(), and _InitRng();
• add types:
  • enum wc_rng_bank_flags
  • struct wc_rng_bank
  • struct wc_rng_bank_inst
• add implementations:
  • wc_rng_bank_init()
  • wc_rng_bank_set_affinity_handlers()
  • wc_rng_bank_fini()
  • wc_rng_bank_checkout()
  • wc_rng_bank_checkin()
  • wc_rng_bank_inst_reinit()
  • wc_rng_bank_seed()
  • wc_rng_bank_reseed()
  • wc_InitRng_BankRef()
  • wc_rng_new_bankref()
  • WC_RNG_BANK_INST_TO_RNG()
• in wc_RNG_GenerateBlock() and wc_FreeRng(), add WC_RNG_BANK_SUPPORT sections;

wolfcrypt/src/random.c: in WC_VERBOSE_RNG messages, add "ERROR: " prefixes to text to assure pickup by autotesting. also fixed line lengths.

linuxkm/lkcapi_sha_glue.c:

• refactor to use new wc_rng_bank facility:
  • wc_linuxkm_drbg_init_tfm()
  • wc_linuxkm_drbg_exit_tfm()
  • get_drbg() (renamed to linuxkm_get_drbg())
  • put_drbg() (renamed to linuxkm_put_drbg())
  • wc_linuxkm_drbg_generate()
  • wc_linuxkm_drbg_seed()
  • wc_mix_pool_bytes()
  • wc_crng_reseed()
• add:
  • linuxkm_affinity_lock()
  • linuxkm_affinity_get_id()
  • linuxkm_affinity_unlock()
  • linuxkm_InitRng_DefaultRef()
• remove:
  • get_drbg_n()
  • drbg_init_from()
  • fork_default_rng()
  • LKCAPI_INITRNG_FOR_SELFTEST
• when LINUXKM_LKCAPI_REGISTER_HASH_DRBG_DEFAULT, define LKCAPI_INITRNG to linuxkm_InitRng_DefaultRef, else define it to wc_InitRng().

linuxkm/{lkcapi_dh_glue.c,lkcapi_ecdh_glue.c,lkcapi_rsa_glue.c}: use LKCAPI_INITRNG() rather than wc_InitRng(), and remove calls to LKCAPI_INITRNG_FOR_SELFTEST(). also, in km_rsa_ctx_init_rng(), recognize WC_DRBG_BANKREF as a usable RNG status.

configure.ac: add handling for --enable-rng-bank, and add it to the all-crypto feature set.

wolfcrypt/src/error.c, wolfssl/wolfcrypt/error-crypt.h: add BUSY_E and ALREADY_E.

wolfcrypt/src/wc_port.c and wolfssl/wolfcrypt/wc_port.h: in wolfSSL_RefFree() and wolfSSL_RefWithMutexFree(), zero the refcount (valid refcount objects are initialized to count of 1); add wolfSSL_RefCur().

wolfssl/wolfcrypt/settings.h:

• add FIPS_VERSION_NE();
• move more generic setup code from WOLFSSL_LINUXKM/WOLFSSL_BSDKM sections to kernel-generic WOLFSSL_KERNEL_MODE section; fix WOLFSSL_OLD_PRIME_CHECK setup to exclude FIPS.

linuxkm/linuxkm_wc_port.h and linuxkm/module_hooks.c: remove WOLFSSL_DEBUG_BACKTRACE_ERROR_CODES gate around setup for wolfssl_linuxkm_pie_redirect_table.dump_stack.

linuxkm/module_hooks.c: in wc_linuxkm_relax_long_loop(), use cpu_relax() as a fallback when non-preemptible.

linuxkm/x86_vector_register_glue.c: in wc_save_vector_registers_x86(), don't render warning of call while non-preemptible if WC_SVR_FLAG_INHIBIT was passed in.

[philljj]

I think all-c89-clang-tidy and all-c89-cppcheck CI had errors.

[philljj]

Looks good so far, just have some suggestions.

[douzzer]

retest this please
(Jenkins glitches X 5)

[dgarske]

The PR review and testing is fine, but I’d really like some more documentation for --enable-rng-bank and WC_RNG_BANK_SUPPORT. Eventually the new rng_bank.c file will need added to CMake and VS project.

Fixed